Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/18373 )
Change subject: IMPALA-10272: LOAD DATA should respect Ranger-HDFS policies ...................................................................... Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/c/18373/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18373/1//COMMIT_MSG@10 PS1, Line 10: fails in nit: fail when http://gerrit.cloudera.org:8080/#/c/18373/1//COMMIT_MSG@13 PS1, Line 13: is a quick fix nit. provides a quick fix http://gerrit.cloudera.org:8080/#/c/18373/1//COMMIT_MSG@13 PS1, Line 13: , we can check : the access using FileSystem#access(Path path, FsAction mode) to invoke a : NameNode RPC to respect Ranger-HDFS policies. nit: . We invoke method hadoop.fs.FileSystem.access(Path path, FsAction mode) to check the actual access permission first. http://gerrit.cloudera.org:8080/#/c/18373/1/fe/src/main/java/org/apache/impala/util/FsPermissionChecker.java File fe/src/main/java/org/apache/impala/util/FsPermissionChecker.java: http://gerrit.cloudera.org:8080/#/c/18373/1/fe/src/main/java/org/apache/impala/util/FsPermissionChecker.java@313 PS1, Line 313: access nit: may need to add a comment for the new method. May also use the name checkAccess(). http://gerrit.cloudera.org:8080/#/c/18373/1/fe/src/main/java/org/apache/impala/util/FsPermissionChecker.java@316 PS1, Line 316: fs.access( Should we handle AccessControlException (https://github.com/apache/hadoop/blob/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileSystem.java#L2698) here and return false instead? -- To view, visit http://gerrit.cloudera.org:8080/18373 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia0acd83e8e237ea6a1d5fe1e9e440db0dd68b09c Gerrit-Change-Number: 18373 Gerrit-PatchSet: 1 Gerrit-Owner: Anonymous Coward <lipeng...@sensorsdata.cn> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Comment-Date: Fri, 01 Apr 2022 17:40:55 +0000 Gerrit-HasComments: Yes
