Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/17735 )
Change subject: IMPALA-10414: fix memory leak when canceling the retried query ...................................................................... Patch Set 9: (1 comment) http://gerrit.cloudera.org:8080/#/c/17735/8/be/src/runtime/query-driver.cc File be/src/runtime/query-driver.cc: http://gerrit.cloudera.org:8080/#/c/17735/8/be/src/runtime/query-driver.cc@368 PS8, Line 368: RETURN_VOID_IF_ERROR(query_handle->Finalize(true, nullptr)); > Different places call ClientRequestState::Cancel() with different parameter Agree. When ClientRequestState::Cancel() is called with wait_until_finalized as true, we have to wait until finalized. Query retry make the cancellation code messy. I recently saw a case for which Coordinator::BackendState::Cancel() was hung and it caused admission resource not been released. I think it's not safe to call ClientRequestState::Cancel() more than once since it call AdmissionControlService::CancelAdmission() and Coordinator::Cancel(). -- To view, visit http://gerrit.cloudera.org:8080/17735 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If804ca65da1794c819a6b2e6567ea7651ab5112f Gerrit-Change-Number: 17735 Gerrit-PatchSet: 9 Gerrit-Owner: Xianqing He <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Sahil Takiar <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Xianqing He <[email protected]> Gerrit-Comment-Date: Mon, 11 Apr 2022 05:24:52 +0000 Gerrit-HasComments: Yes
