Xianqing He has posted comments on this change. (
http://gerrit.cloudera.org:8080/17735 )
Change subject: IMPALA-10414: fix memory leak when canceling the retried query
......................................................................
Patch Set 10:
> Patch Set 9:
>
> Ran debug exhaustive test and asan test for this patch, plus following minor
> changes for ClientRequestState::Cancel()
>
> - admission_control_client_->CancelAdmission();
> - is_cancelled_ = true;
> + if (!is_cancelled_) {
> + admission_control_client_->CancelAdmission();
> + is_cancelled_ = true;
> + }
> } // Release lock_ before doing cancellation work.
>
> Passed debug exhaustive test without error
> (https://jenkins.impala.io/job/pre-review-test/1323/)
> Got one failure (TestAcid.test_lock_timings) for asan test.
> (https://master-03.jenkins.cloudera.com/job/impala-private-parameterized/915/).
> I think this failure is unrelavent.
Thanks for testing it. I had fixed as this.
--
To view, visit http://gerrit.cloudera.org:8080/17735
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If804ca65da1794c819a6b2e6567ea7651ab5112f
Gerrit-Change-Number: 17735
Gerrit-PatchSet: 10
Gerrit-Owner: Xianqing He <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Sahil Takiar <[email protected]>
Gerrit-Reviewer: Wenzhe Zhou <[email protected]>
Gerrit-Reviewer: Xianqing He <[email protected]>
Gerrit-Comment-Date: Thu, 14 Apr 2022 11:00:48 +0000
Gerrit-HasComments: No
