Xianqing He has uploaded a new patch set (#10). ( http://gerrit.cloudera.org:8080/17735 )
Change subject: IMPALA-10414: fix memory leak when canceling the retried query ...................................................................... IMPALA-10414: fix memory leak when canceling the retried query The query retry launches in a separate thread. This thread may not finishes when deleting the query from the given QueryDriverMap if the query retry was failed launched. In this case, the resources for the query retry thread will not release. So the reference count of QueryDriver (via the shared_ptr) will not go to 0 and it will not be destroyed. We need wait until the query retry thread execution has completed when deleting the query from the given QueryDiverMap. Testing: Modify the test_query_retries.py to verify memory leak by checking the debug web UI of memz. Change-Id: If804ca65da1794c819a6b2e6567ea7651ab5112f --- M be/src/runtime/query-driver.cc M be/src/service/client-request-state.cc M tests/custom_cluster/test_query_retries.py 3 files changed, 37 insertions(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/35/17735/10 -- To view, visit http://gerrit.cloudera.org:8080/17735 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: If804ca65da1794c819a6b2e6567ea7651ab5112f Gerrit-Change-Number: 17735 Gerrit-PatchSet: 10 Gerrit-Owner: Xianqing He <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Sahil Takiar <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Xianqing He <[email protected]>
