wangsheng has posted comments on this change. ( http://gerrit.cloudera.org:8080/18452 )
Change subject: IMPALA-11248 Fix infinite warning dialog issue when datatable cells has undefined values in rpcz web page ...................................................................... Patch Set 1: (6 comments) Thanks for this bug fixing, carolinchen, just some nits. http://gerrit.cloudera.org:8080/#/c/18452/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18452/1//COMMIT_MSG@7 PS1, Line 7: has have http://gerrit.cloudera.org:8080/#/c/18452/1//COMMIT_MSG@7 PS1, Line 7: rpcz web page www/rpcz.tmpl http://gerrit.cloudera.org:8080/#/c/18452/1//COMMIT_MSG@7 PS1, Line 7: Need ':' here http://gerrit.cloudera.org:8080/#/c/18452/1//COMMIT_MSG@10 PS1, Line 10: some kernel environment Maybe we should list some examples here, such as centos?ubuntu? http://gerrit.cloudera.org:8080/#/c/18452/1//COMMIT_MSG@10 PS1, Line 10: with no without http://gerrit.cloudera.org:8080/#/c/18452/1//COMMIT_MSG@21 PS1, Line 21: 1. Maybe we can use '-' here. -- To view, visit http://gerrit.cloudera.org:8080/18452 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7f284b4419ba7dd72baa960dcd5700da22dccdff Gerrit-Change-Number: 18452 Gerrit-PatchSet: 1 Gerrit-Owner: carolinchen <[email protected]> Gerrit-Reviewer: Fucun Chu <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: wangsheng <[email protected]> Gerrit-Comment-Date: Wed, 27 Apr 2022 08:42:33 +0000 Gerrit-HasComments: Yes
