Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18452 )
Change subject: IMPALA-11248 Fix infinite warning dialog issue when datatable cells has undefined values in rpcz web page ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Hi Carolin, could you please address the above comments? I think we are close to release 4.1 so would like this to get merged. http://gerrit.cloudera.org:8080/#/c/18452/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18452/1//COMMIT_MSG@23 PS1, Line 23: without any warning dialog and auto-refresh normally. > I guess the issue could be re-produced in this test case. Please mention th I can't reproduce the issue locally. Maybe it's ok to not adding the test since the fix seems harmless. -- To view, visit http://gerrit.cloudera.org:8080/18452 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7f284b4419ba7dd72baa960dcd5700da22dccdff Gerrit-Change-Number: 18452 Gerrit-PatchSet: 1 Gerrit-Owner: carolinchen <[email protected]> Gerrit-Reviewer: Fucun Chu <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: wangsheng <[email protected]> Gerrit-Comment-Date: Fri, 06 May 2022 01:52:04 +0000 Gerrit-HasComments: Yes
