carolinchen has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/18452 )

Change subject: IMPALA-11248: Fix infinite warning dialog issue when datatable 
cells have undefined values in www/rpcz web page
......................................................................


Patch Set 2:

(6 comments)

http://gerrit.cloudera.org:8080/#/c/18452/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/18452/1//COMMIT_MSG@7
PS1, Line 7: :
> Need ':' here
Done


http://gerrit.cloudera.org:8080/#/c/18452/1//COMMIT_MSG@7
PS1, Line 7:  ha
> have
Done


http://gerrit.cloudera.org:8080/#/c/18452/1//COMMIT_MSG@10
PS1, Line 10: some kernel environment
> Maybe we should list some examples here, such as centos?ubuntu?
Done


http://gerrit.cloudera.org:8080/#/c/18452/1//COMMIT_MSG@10
PS1, Line 10: in cent
> without
Done


http://gerrit.cloudera.org:8080/#/c/18452/1//COMMIT_MSG@21
PS1, Line 21: Te
> Maybe we can use '-' here.
Done


http://gerrit.cloudera.org:8080/#/c/18452/1//COMMIT_MSG@23
PS1, Line 23: the page display the KRPC inbound/outbound connection
> I guess the issue could be re-produced in this test case. Please mention th
this issue just happen in some special environment, we reproduce the issue in 
centOS linux release 7.2 and tencent tlinux release 2.2



--
To view, visit http://gerrit.cloudera.org:8080/18452
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7f284b4419ba7dd72baa960dcd5700da22dccdff
Gerrit-Change-Number: 18452
Gerrit-PatchSet: 2
Gerrit-Owner: carolinchen <[email protected]>
Gerrit-Reviewer: Fucun Chu <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Wenzhe Zhou <[email protected]>
Gerrit-Reviewer: carolinchen <[email protected]>
Gerrit-Reviewer: wangsheng <[email protected]>
Gerrit-Comment-Date: Mon, 09 May 2022 03:18:18 +0000
Gerrit-HasComments: Yes

Reply via email to