Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/18531 )
Change subject: IMPALA-10453: Support file pruning via runtime filters on Iceberg ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/18531/1/be/src/exec/hdfs-scan-node-base.h File be/src/exec/hdfs-scan-node-base.h: http://gerrit.cloudera.org:8080/#/c/18531/1/be/src/exec/hdfs-scan-node-base.h@642 PS1, Line 642: int32_t > this is int64_t in FileMetadataUtils about constness: In general we don't use const for primitive arguments passed by value in Impala. http://gerrit.cloudera.org:8080/#/c/18531/1/testdata/workloads/functional-query/queries/QueryTest/iceberg-partition-runtime-filter.test File testdata/workloads/functional-query/queries/QueryTest/iceberg-partition-runtime-filter.test: http://gerrit.cloudera.org:8080/#/c/18531/1/testdata/workloads/functional-query/queries/QueryTest/iceberg-partition-runtime-filter.test@9 PS1, Line 9: BY SPEC (col_1, col_2, col_3) Will this also work with non-identity partitioning, for example the day part of a timestamp? http://gerrit.cloudera.org:8080/#/c/18531/1/testdata/workloads/functional-query/queries/QueryTest/iceberg-partition-runtime-filter.test@13 PS1, Line 13: (1, 1, "a", "a"); Can you do an insert with more than one rows? -- To view, visit http://gerrit.cloudera.org:8080/18531 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7762e1238bdf236b85d2728881a402a2bb41f36a Gerrit-Change-Number: 18531 Gerrit-PatchSet: 1 Gerrit-Owner: Tamas Mate <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Gergely Fürnstáhl <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Tue, 17 May 2022 06:32:44 +0000 Gerrit-HasComments: Yes
