Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18531 )
Change subject: IMPALA-10453: Support file pruning via runtime filters on Iceberg ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/18531/4/fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java File fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java: http://gerrit.cloudera.org:8080/#/c/18531/4/fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java@268 PS4, Line 268: partField.getTransformType() == TIcebergPartitionTransformType.IDENTITY) this extra condition disables runtime filter generation for all partition transform columns other than IDENTITY. Also, the function name 'isComputedPartitionColumn' also suggests any column that participates in partitioning. See also the comment in FeTable. Unfortunately this also revealed a gap in our testing. http://gerrit.cloudera.org:8080/#/c/18531/4/testdata/workloads/functional-query/queries/QueryTest/iceberg-in-predicate-push-down.test File testdata/workloads/functional-query/queries/QueryTest/iceberg-in-predicate-push-down.test: http://gerrit.cloudera.org:8080/#/c/18531/4/testdata/workloads/functional-query/queries/QueryTest/iceberg-in-predicate-push-down.test@a59 PS4, Line 59: Why do we remove these sections? -- To view, visit http://gerrit.cloudera.org:8080/18531 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7762e1238bdf236b85d2728881a402a2bb41f36a Gerrit-Change-Number: 18531 Gerrit-PatchSet: 4 Gerrit-Owner: Tamas Mate <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Gergely Fürnstáhl <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tamas Mate <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Tue, 14 Jun 2022 12:51:41 +0000 Gerrit-HasComments: Yes
