Gergely Fürnstáhl has posted comments on this change. ( http://gerrit.cloudera.org:8080/18531 )
Change subject: IMPALA-10453: Support file pruning via runtime filters on Iceberg ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/18531/1/be/src/exec/file-metadata-utils.h File be/src/exec/file-metadata-utils.h: http://gerrit.cloudera.org:8080/#/c/18531/1/be/src/exec/file-metadata-utils.h@49 PS1, Line 49: HdfsScanNodeBase* scan_node_; > Setting this to const escalates a bit, GetTemplateTupleForPartitionId has t nit: I meant const pointer, not pointer to const, as it does not change after init https://godbolt.org/z/qfGxsPbhr I wanted to suggest reference first, but saw that we exploit nullability for testing. Being const is still helpful for the reader in my opinion, reduces the complexity of the code (no need to worry whether it changes anywhere in the file or not). -- To view, visit http://gerrit.cloudera.org:8080/18531 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7762e1238bdf236b85d2728881a402a2bb41f36a Gerrit-Change-Number: 18531 Gerrit-PatchSet: 1 Gerrit-Owner: Tamas Mate <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Gergely Fürnstáhl <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tamas Mate <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Mon, 23 May 2022 13:02:19 +0000 Gerrit-HasComments: Yes
