Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/18536 )
Change subject: IMPALA-10465: Use IGNORE variant of Kudu write operations ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/18536/1/be/src/exec/kudu-table-sink.cc File be/src/exec/kudu-table-sink.cc: http://gerrit.cloudera.org:8080/#/c/18536/1/be/src/exec/kudu-table-sink.cc@57 PS1, Line 57: true Default behavior is changed. Need to document it. http://gerrit.cloudera.org:8080/#/c/18536/1/be/src/exec/kudu-table-sink.cc@358 PS1, Line 358: } What's the value of session_->CountPendingErrors() if ignore_conflicts_ is true? Add comments if it's 0. Otherwise, we still fetch all pending errors if transaction is not enabled. -- To view, visit http://gerrit.cloudera.org:8080/18536 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8da7c41d61b0888378b390b8b643238433eb3b52 Gerrit-Change-Number: 18536 Gerrit-PatchSet: 1 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Wed, 18 May 2022 03:08:51 +0000 Gerrit-HasComments: Yes
