Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/18536 )
Change subject: IMPALA-10465: Use IGNORE variant of Kudu write operations ...................................................................... Patch Set 3: (3 comments) In patch set 2, I decide to change the workload using lineitem table of tpch. This is to get a bit longer query latency and better alignment with targeted-perf workload, which load tpch data. http://gerrit.cloudera.org:8080/#/c/18536/1/be/src/exec/kudu-table-sink.cc File be/src/exec/kudu-table-sink.cc: http://gerrit.cloudera.org:8080/#/c/18536/1/be/src/exec/kudu-table-sink.cc@57 PS1, Line 57: havi > Default behavior is changed. Need to document it. Done http://gerrit.cloudera.org:8080/#/c/18536/1/be/src/exec/kudu-table-sink.cc@358 PS1, Line 358: i > What's the value of session_->CountPendingErrors() if ignore_conflicts_ is Added comment and DCHECK. http://gerrit.cloudera.org:8080/#/c/18536/1/tests/custom_cluster/test_kudu.py File tests/custom_cluster/test_kudu.py: http://gerrit.cloudera.org:8080/#/c/18536/1/tests/custom_cluster/test_kudu.py@337 PS1, Line 337: TestKuduTransaction > Add new test cases with flag kudu_ignore_conflicts as false. Done -- To view, visit http://gerrit.cloudera.org:8080/18536 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8da7c41d61b0888378b390b8b643238433eb3b52 Gerrit-Change-Number: 18536 Gerrit-PatchSet: 3 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Wed, 18 May 2022 21:20:52 +0000 Gerrit-HasComments: Yes
