Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/18536 )
Change subject: IMPALA-10465: Use IGNORE variant of Kudu write operations ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/18536/2/be/src/exec/kudu-table-sink.cc File be/src/exec/kudu-table-sink.cc: http://gerrit.cloudera.org:8080/#/c/18536/2/be/src/exec/kudu-table-sink.cc@360 PS2, Line 360: // Since ignore_conflicts_ is true, there should be no Kudu error message. : DCHECK(session_->CountPendingErrors() == 0); Should we move these two lines after line #350, and return Status:OK() after line #364? http://gerrit.cloudera.org:8080/#/c/18536/2/tests/custom_cluster/test_kudu.py File tests/custom_cluster/test_kudu.py: http://gerrit.cloudera.org:8080/#/c/18536/2/tests/custom_cluster/test_kudu.py@630 PS2, Line 630: class TestKuduTransactionNoIgnore(TestKuduTransaction) Why define a new class? can we call member functions in class TestKuduTransaction? -- To view, visit http://gerrit.cloudera.org:8080/18536 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8da7c41d61b0888378b390b8b643238433eb3b52 Gerrit-Change-Number: 18536 Gerrit-PatchSet: 2 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Wed, 18 May 2022 21:20:41 +0000 Gerrit-HasComments: Yes
