Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/18219 )
Change subject: IMPALA-11064 Optimizing Temporary File Structure for Batch Reading ...................................................................... Patch Set 4: (5 comments) Only about halfway through, and don't fully understand the changes yet, but I had a few initial comments/questions. http://gerrit.cloudera.org:8080/#/c/18219/4/be/src/exec/partitioned-hash-join-builder.h File be/src/exec/partitioned-hash-join-builder.h: http://gerrit.cloudera.org:8080/#/c/18219/4/be/src/exec/partitioned-hash-join-builder.h@547 PS4, Line 547: uint64_t GenerateBaseSpillId(int64_t level) { This appears to be duplicated in partitioned-hash-join-node.h. There's nothing class-specific about it, you could pull it out to a helper function. http://gerrit.cloudera.org:8080/#/c/18219/4/be/src/runtime/bufferpool/buffer-pool.h File be/src/runtime/bufferpool/buffer-pool.h: http://gerrit.cloudera.org:8080/#/c/18219/4/be/src/runtime/bufferpool/buffer-pool.h@412 PS4, Line 412: friend class BufferedTupleStream; I don't see why this is needed. http://gerrit.cloudera.org:8080/#/c/18219/4/be/src/runtime/bufferpool/buffer-pool.h@538 PS4, Line 538: void SetSpillId(uint64_t spill_id) { spill_id_ = spill_id; } Different styles for setters and getters seems odd, but I'll assume this is consistent with Impala's existing style. http://gerrit.cloudera.org:8080/#/c/18219/4/be/src/runtime/io/disk-file.h File be/src/runtime/io/disk-file.h: http://gerrit.cloudera.org:8080/#/c/18219/4/be/src/runtime/io/disk-file.h@20 PS4, Line 20: #include <fstream> Why is this inclusion needed? http://gerrit.cloudera.org:8080/#/c/18219/4/be/src/runtime/io/disk-file.h@569 PS4, Line 569: bool to_delete_ = false; Why switch all these from atomic to locking? -- To view, visit http://gerrit.cloudera.org:8080/18219 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If913785cac9e2dafa20013b6600c87fcaf3e2018 Gerrit-Change-Number: 18219 Gerrit-PatchSet: 4 Gerrit-Owner: Yida Wu <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Tue, 14 Jun 2022 22:17:11 +0000 Gerrit-HasComments: Yes
