Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/18219 )
Change subject: IMPALA-11064 Optimizing Temporary File Structure for Batch Reading ...................................................................... Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/18219/4/be/src/runtime/io/local-file-writer.cc File be/src/runtime/io/local-file-writer.cc: http://gerrit.cloudera.org:8080/#/c/18219/4/be/src/runtime/io/local-file-writer.cc@92 PS4, Line 92: written_bytes_ += write_range->len(); We only update written_bytes_ if you pass in a ref to get the value? Could there be mixed use of WriteOne? http://gerrit.cloudera.org:8080/#/c/18219/4/be/src/runtime/io/request-context.cc File be/src/runtime/io/request-context.cc: http://gerrit.cloudera.org:8080/#/c/18219/4/be/src/runtime/io/request-context.cc@577 PS4, Line 577: if (state_ != RequestContext::Active) return CONTEXT_CANCELLED; This needs some explanation. Why is it different from AddWriteRange and IsCancelled? http://gerrit.cloudera.org:8080/#/c/18219/4/be/src/runtime/tmp-file-mgr.cc File be/src/runtime/tmp-file-mgr.cc: http://gerrit.cloudera.org:8080/#/c/18219/4/be/src/runtime/tmp-file-mgr.cc@123 PS4, Line 123: "size would be the nth power of 2"); End sentence with a period for consistency. -- To view, visit http://gerrit.cloudera.org:8080/18219 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If913785cac9e2dafa20013b6600c87fcaf3e2018 Gerrit-Change-Number: 18219 Gerrit-PatchSet: 4 Gerrit-Owner: Yida Wu <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Wed, 15 Jun 2022 18:01:05 +0000 Gerrit-HasComments: Yes
