Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/18219 )
Change subject: IMPALA-11064 Optimizing Temporary File Structure for Batch Reading ...................................................................... Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/18219/4/be/src/runtime/io/request-context.cc File be/src/runtime/io/request-context.cc: http://gerrit.cloudera.org:8080/#/c/18219/4/be/src/runtime/io/request-context.cc@577 PS4, Line 577: // It is possible that the RequestContext is in Inactive state for remote ranges. > Added some comments. Previously we don't allow any access to the context in Done http://gerrit.cloudera.org:8080/#/c/18219/5/be/src/runtime/tmp-file-mgr.h File be/src/runtime/tmp-file-mgr.h: http://gerrit.cloudera.org:8080/#/c/18219/5/be/src/runtime/tmp-file-mgr.h@617 PS5, Line 617: uint64_t EnqueueTmpBlockBySpillId(uint64_t spill_id, TmpBlock* tmp_block) { This violates the comments at 507 that > Public methods of TmpFileGroup and TmpWriteHandle are safe to call > concurrently from > multiple threads as long as different TmpWriteHandle arguments are provided. I think that's why I called it out, along with UpdateLatestBlockById and EnqueueNewFile. We should note they're not threadsafe. -- To view, visit http://gerrit.cloudera.org:8080/18219 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If913785cac9e2dafa20013b6600c87fcaf3e2018 Gerrit-Change-Number: 18219 Gerrit-PatchSet: 5 Gerrit-Owner: Yida Wu <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Thu, 23 Jun 2022 23:01:47 +0000 Gerrit-HasComments: Yes
