Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18641 )
Change subject: IMPALA-11320: SHOW PARTITIONS on Iceberg table doesn't list the partitions ...................................................................... Patch Set 4: (5 comments) Thanks for working on this. Had a few comments, but the change looks great overall. http://gerrit.cloudera.org:8080/#/c/18641/4/fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java File fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java: http://gerrit.cloudera.org:8080/#/c/18641/4/fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java@310 PS4, Line 310: resultSchema.addToColumns(new TColumn("Number Of Files", Type.BIGINT.toThrift())); : resultSchema.addToColumns(new TColumn("Number Of Rows", Type.BIGINT.toThrift())); Seems like Hive outputs "Number of Rows" first, then "Number of Files": https://github.com/apache/hive/blame/2a0f91e2503ac76bad0370b29fbcc95ad162b560/iceberg/iceberg-handler/src/test/results/positive/query_iceberg_metadata_of_partitioned_table.q.out#L479-L485 Can we have tests where the "Number of Rows" and "Number of Files" differ? http://gerrit.cloudera.org:8080/#/c/18641/4/fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java@581 PS4, Line 581: partValueString = table.getNullPartitionKeyValue(); Please add test for NULL partition key value. http://gerrit.cloudera.org:8080/#/c/18641/4/fe/src/main/java/org/apache/impala/catalog/local/LocalIcebergTable.java File fe/src/main/java/org/apache/impala/catalog/local/LocalIcebergTable.java: http://gerrit.cloudera.org:8080/#/c/18641/4/fe/src/main/java/org/apache/impala/catalog/local/LocalIcebergTable.java@77 PS4, Line 77: private Map<String, TIcebergPartitionContent> partitionContent_; Seems like it doesn't get initialized anywhere. Can you please try out your patch using local catalog mode: bin/start-impala-cluster.py --impalad_args --use_local_catalog=true --catalogd_args --catalog_topic_mode=minimal http://gerrit.cloudera.org:8080/#/c/18641/4/fe/src/main/java/org/apache/impala/catalog/local/LocalIcebergTable.java@123 PS4, Line 123: defaultPartitionSpecId_ = tableInfo.getIceberg_table().getDefault_partition_spec_id(); I think we could initialize 'partitionContent_' somewhere here. http://gerrit.cloudera.org:8080/#/c/18641/4/testdata/workloads/functional-query/queries/QueryTest/iceberg-create.test File testdata/workloads/functional-query/queries/QueryTest/iceberg-create.test: http://gerrit.cloudera.org:8080/#/c/18641/4/testdata/workloads/functional-query/queries/QueryTest/iceberg-create.test@40 PS4, Line 40: SHOW PARTITIONS iceberg_hadoop_tables; Maybe we can keep one 'SHOW PARTITIONS', but the others seem quite unnecessary. -- To view, visit http://gerrit.cloudera.org:8080/18641 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3b4399ae924dadb89875735b12a2f92453b6754c Gerrit-Change-Number: 18641 Gerrit-PatchSet: 4 Gerrit-Owner: Xiaoqing Gao <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tamas Mate <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Tue, 21 Jun 2022 13:18:00 +0000 Gerrit-HasComments: Yes
