[email protected] has posted comments on this change. ( http://gerrit.cloudera.org:8080/18641 )
Change subject: IMPALA-11320: SHOW PARTITIONS on Iceberg table doesn't list the partitions ...................................................................... Patch Set 4: Code-Review+1 (2 comments) Thanks a lot for the commit. The overall logic is good. Had a few comments. http://gerrit.cloudera.org:8080/#/c/18641/4/fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java File fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java: http://gerrit.cloudera.org:8080/#/c/18641/4/fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java@565 PS4, Line 565: loadPartitionContent Could you please separate this to two functions? - one return a json string represents the partition key - another would wrap partitionKey and icebergPartitionContent in Map<String, TIcebergPartitionContent> http://gerrit.cloudera.org:8080/#/c/18641/4/fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java@574 PS4, Line 574: map rename it 'fieldNameToPartitionValue' to make a little bit more sense. -- To view, visit http://gerrit.cloudera.org:8080/18641 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3b4399ae924dadb89875735b12a2f92453b6754c Gerrit-Change-Number: 18641 Gerrit-PatchSet: 4 Gerrit-Owner: Xiaoqing Gao <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tamas Mate <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Wed, 22 Jun 2022 04:11:57 +0000 Gerrit-HasComments: Yes
