Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18648 )
Change subject: IMPALA-11377: Handle concurrent Iceberg INSERT OVERWRITEs ...................................................................... Patch Set 1: (9 comments) Found a couple of nits, but looks good overall. http://gerrit.cloudera.org:8080/#/c/18648/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18648/1//COMMIT_MSG@9 PS1, Line 9: l nit: we limit commit message lines to 72 chars width. http://gerrit.cloudera.org:8080/#/c/18648/1/common/thrift/CatalogService.thrift File common/thrift/CatalogService.thrift: http://gerrit.cloudera.org:8080/#/c/18648/1/common/thrift/CatalogService.thrift@218 PS1, Line 218: spanshopt typo http://gerrit.cloudera.org:8080/#/c/18648/1/fe/src/main/java/org/apache/impala/service/IcebergCatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/IcebergCatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/18648/1/fe/src/main/java/org/apache/impala/service/IcebergCatalogOpExecutor.java@310 PS1, Line 310: ImpalaRuntimeException(e.getMessage()); nit: maybe we could also add `e` as the cause to get more information: ImpalaRuntimeException(e.getMessage(), e); http://gerrit.cloudera.org:8080/#/c/18648/1/tests/query_test/test_iceberg.py File tests/query_test/test_iceberg.py: http://gerrit.cloudera.org:8080/#/c/18648/1/tests/query_test/test_iceberg.py@76 PS1, Line 76: @SkipIf.not_hdfs Can we remove this? http://gerrit.cloudera.org:8080/#/c/18648/1/tests/query_test/test_iceberg.py@84 PS1, Line 84: @SkipIf.not_hdfs I don't think we need this annotation here. http://gerrit.cloudera.org:8080/#/c/18648/1/tests/query_test/test_iceberg.py@95 PS1, Line 95: cat_location = "/test-warehouse/" + unique_database we can just create a default HiveCatalog table http://gerrit.cloudera.org:8080/#/c/18648/1/tests/query_test/test_iceberg.py@99 PS1, Line 99: tblproperties('iceberg.catalog'='hadoop.catalog', : 'iceberg.catalog_location'='{1}')""".format(tbl_name, cat_location)) No need for these params http://gerrit.cloudera.org:8080/#/c/18648/1/tests/query_test/test_iceberg.py@101 PS1, Line 101: self.client.execute("insert into {0} values (1), (2), (3);".format(tbl_name)) nit: maybe add a comment that it is for warm-up. http://gerrit.cloudera.org:8080/#/c/18648/1/tests/query_test/test_iceberg.py@103 PS1, Line 103: insert overwrite we could have a test with INSERT INTO as well -- To view, visit http://gerrit.cloudera.org:8080/18648 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I812d19736c8e563541b038970786de7710b59f31 Gerrit-Change-Number: 18648 Gerrit-PatchSet: 1 Gerrit-Owner: Tamas Mate <[email protected]> Gerrit-Reviewer: Gergely Fürnstáhl <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Wed, 22 Jun 2022 11:35:09 +0000 Gerrit-HasComments: Yes
