Gergely Fürnstáhl has posted comments on this change. ( http://gerrit.cloudera.org:8080/18648 )
Change subject: IMPALA-11377: Handle concurrent Iceberg INSERT OVERWRITEs ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Small additional nit-pick, otherwise LGTM http://gerrit.cloudera.org:8080/#/c/18648/1/tests/query_test/test_iceberg.py File tests/query_test/test_iceberg.py: http://gerrit.cloudera.org:8080/#/c/18648/1/tests/query_test/test_iceberg.py@117 PS1, Line 117: assert exception is not None nit: maybe this is a bit cleaner (and more widely used among our tests): try: self.client.wait_for_finished_timeout(handle, 30) assert False except ImpalaBeeswaxException as e: -- To view, visit http://gerrit.cloudera.org:8080/18648 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I812d19736c8e563541b038970786de7710b59f31 Gerrit-Change-Number: 18648 Gerrit-PatchSet: 1 Gerrit-Owner: Tamas Mate <[email protected]> Gerrit-Reviewer: Gergely Fürnstáhl <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Wed, 22 Jun 2022 15:03:17 +0000 Gerrit-HasComments: Yes
