Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18648 )
Change subject: IMPALA-11331: Handle concurrent Iceberg INSERT OVERWRITEs ...................................................................... Patch Set 3: Code-Review+2 (1 comment) One small nit, otherwise the change looks great! http://gerrit.cloudera.org:8080/#/c/18648/3/tests/query_test/test_iceberg.py File tests/query_test/test_iceberg.py: http://gerrit.cloudera.org:8080/#/c/18648/3/tests/query_test/test_iceberg.py@122 PS3, Line 122: re.search("Found conflicting files.*", str(e)) nit: you can just use "Found conflicting files" in str(e) No need for the re module. -- To view, visit http://gerrit.cloudera.org:8080/18648 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I812d19736c8e563541b038970786de7710b59f31 Gerrit-Change-Number: 18648 Gerrit-PatchSet: 3 Gerrit-Owner: Tamas Mate <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Gergely Fürnstáhl <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tamas Mate <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Thu, 30 Jun 2022 17:31:56 +0000 Gerrit-HasComments: Yes
