Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18652 )
Change subject: IMPALA-11344: Missing slots for non-Iceberg and non-FullAcid tables should be allowed to be read ...................................................................... Patch Set 8: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/18652/8/be/src/exec/orc-column-readers.cc File be/src/exec/orc-column-readers.cc: http://gerrit.cloudera.org:8080/#/c/18652/8/be/src/exec/orc-column-readers.cc@453 PS8, Line 453: // vector batch (the write id batch). Please comment the last case, i.e. we allow empty 'children_' if all required fields are missing in the files, and the table is non-ACID and non-Iceberg table. -- To view, visit http://gerrit.cloudera.org:8080/18652 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I15dca47ba5f7a93bfd5fcba3cab4ac6d64459023 Gerrit-Change-Number: 18652 Gerrit-PatchSet: 8 Gerrit-Owner: ttttttz <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: ttttttz <[email protected]> Gerrit-Comment-Date: Fri, 24 Jun 2022 03:10:13 +0000 Gerrit-HasComments: Yes
