Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18652 )
Change subject: IMPALA-11344: Missing slots for non-Iceberg and non-FullAcid tables should be allowed to be read ...................................................................... Patch Set 9: (1 comment) http://gerrit.cloudera.org:8080/#/c/18652/9/be/src/exec/orc-column-readers.cc File be/src/exec/orc-column-readers.cc: http://gerrit.cloudera.org:8080/#/c/18652/9/be/src/exec/orc-column-readers.cc@457 PS9, Line 457: valid_empty_children_ = scanner_->acid_original_file_ || I think we should allow empty children whenever we only scan partition slots and/or all slots are missing in the file. E.g. we still get an error in the following case: In Hive> create table full_txn_test (i int) stored as orc tblproperties ('transactional'='true'); insert into full_txn_test values (3); alter table full_txn_test add columns (j int); insert into full_txn_test values (1,2); select j from full_txn_test; +-------+ | j | +-------+ | NULL | | 2 | +-------+ In Impala> select j from full_txn_test; ERROR: Parse error in possibly corrupt ORC file: 'hdfs://localhost:20500/test-warehouse/managed/full_txn_test/delta_0000001_0000001_0000/bucket_00000_0'. No columns found for this scan. -- To view, visit http://gerrit.cloudera.org:8080/18652 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I15dca47ba5f7a93bfd5fcba3cab4ac6d64459023 Gerrit-Change-Number: 18652 Gerrit-PatchSet: 9 Gerrit-Owner: ttttttz <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: ttttttz <[email protected]> Gerrit-Comment-Date: Tue, 28 Jun 2022 09:31:39 +0000 Gerrit-HasComments: Yes
