Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18652 )
Change subject: IMPALA-11344: Missing slots for non-Iceberg and non-FullAcid tables should be allowed to be read ...................................................................... Patch Set 9: -Code-Review (1 comment) http://gerrit.cloudera.org:8080/#/c/18652/9/be/src/exec/orc-column-readers.cc File be/src/exec/orc-column-readers.cc: http://gerrit.cloudera.org:8080/#/c/18652/9/be/src/exec/orc-column-readers.cc@457 PS9, Line 457: valid_empty_children_ = scanner_->acid_original_file_ || > I think we should allow empty children whenever we only scan partition slot It seems if children_ is empty, all the slots are either partition slot or missing field slot or virtual slot, because we always add a child in CreateChildForSlot() at line 447. Should we allow all cases except iceberg tables? I'm also not sure what iceberg cases we should throw ParseError. Maybe we can just skip this valid_empty_children_ check. -- To view, visit http://gerrit.cloudera.org:8080/18652 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I15dca47ba5f7a93bfd5fcba3cab4ac6d64459023 Gerrit-Change-Number: 18652 Gerrit-PatchSet: 9 Gerrit-Owner: ttttttz <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: ttttttz <[email protected]> Gerrit-Comment-Date: Thu, 30 Jun 2022 13:02:01 +0000 Gerrit-HasComments: Yes
