Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/18684 )
Change subject: IMPALA-10122 (Part 2): Allow accessing views created by non-superusers ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/18684/1/tests/authorization/test_ranger.py File tests/authorization/test_ranger.py: http://gerrit.cloudera.org:8080/#/c/18684/1/tests/authorization/test_ranger.py@1531 PS1, Line 1531: @ > I am a bit confused by this check. The indentation of the tests added in th Yes, your code is fine. The linter is flagging it incorrectly because https://gerrit.cloudera.org/c/18669/ was merged earlier today. It aimed to update flake8 and set 'indent-size = 2', which changes indentation checks to expect 2 spaces instead of 4; that meant we could remove exceptions for E111 and E114.. But the gerrit check uses a different version of flake8 and doesn't recognize indent-size. -- To view, visit http://gerrit.cloudera.org:8080/18684 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I50a50931c6eeb0feec28c30531b09269622e6aad Gerrit-Change-Number: 18684 Gerrit-PatchSet: 1 Gerrit-Owner: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Vincent Tran <[email protected]> Gerrit-Comment-Date: Thu, 30 Jun 2022 22:42:42 +0000 Gerrit-HasComments: Yes
