Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/18684 )
Change subject: IMPALA-10122 (Part 2): Allow accessing views created by non-superusers ...................................................................... Patch Set 2: (1 comment) > Patch Set 2: > > (4 comments) > > Hi all, I have revised the patch according to Quanlong's comments in the > previous iteration. Let me know if you have any other suggestion. > > Thank you very much for the help! http://gerrit.cloudera.org:8080/#/c/18684/1/tests/authorization/test_ranger.py File tests/authorization/test_ranger.py: http://gerrit.cloudera.org:8080/#/c/18684/1/tests/authorization/test_ranger.py@1582 PS1, Line 1582: impalad_args=LOCAL_CATALOG_IMPALAD_ARGS, > Yes. We can add such a test. We should be able to avoid the resource collision by creating a view in a unique database. It would make this E2E test much less vulnerable to newly added authorization tests involving the same column in the future. I will try to see if I can revise this E2E test in the next patch. -- To view, visit http://gerrit.cloudera.org:8080/18684 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I50a50931c6eeb0feec28c30531b09269622e6aad Gerrit-Change-Number: 18684 Gerrit-PatchSet: 2 Gerrit-Owner: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Vincent Tran <[email protected]> Gerrit-Comment-Date: Sat, 02 Jul 2022 22:22:58 +0000 Gerrit-HasComments: Yes
