Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18684 )
Change subject: IMPALA-10122 (Part 2): Allow accessing views created by non-superusers ...................................................................... Patch Set 2: Code-Review+1 (1 comment) The patch LGTM. I'd like to see if other reviewers have further comments. If not, I can bump to +2. http://gerrit.cloudera.org:8080/#/c/18684/1/tests/authorization/test_ranger.py File tests/authorization/test_ranger.py: http://gerrit.cloudera.org:8080/#/c/18684/1/tests/authorization/test_ranger.py@1568 PS1, Line 1568: # resource from a role, but we do not have to handle such an exception. We only > Thanks Quanlong! I see. So column-level SELECT privileges do imply VIEW_METADATA privilege and we don't need to hide the underlying table name in the error message. Thanks for the explanation! -- To view, visit http://gerrit.cloudera.org:8080/18684 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I50a50931c6eeb0feec28c30531b09269622e6aad Gerrit-Change-Number: 18684 Gerrit-PatchSet: 2 Gerrit-Owner: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Vincent Tran <[email protected]> Gerrit-Comment-Date: Sat, 02 Jul 2022 02:24:44 +0000 Gerrit-HasComments: Yes
