Gergely Fürnstáhl has posted comments on this change. ( http://gerrit.cloudera.org:8080/18639 )
Change subject: IMPALA-11034: Resolve schema of old data files in migrated Iceberg tables ...................................................................... Patch Set 14: (5 comments) http://gerrit.cloudera.org:8080/#/c/18639/12/be/src/exec/orc-metadata-utils.cc File be/src/exec/orc-metadata-utils.cc: http://gerrit.cloudera.org:8080/#/c/18639/12/be/src/exec/orc-metadata-utils.cc@310 PS12, Line 310: if (LIKELY(child->hasAttributeKey(ICEBERG_FIELD_ID))) { > nit: I think you could add UNLIKELY here Done http://gerrit.cloudera.org:8080/#/c/18639/12/be/src/exec/orc-metadata-utils.cc@311 PS12, Line 311: std::string field_id_str = child->getAttributeValue(ICEBERG_FIELD_ID); > During init we only checked whether the root type's first child has field i Done http://gerrit.cloudera.org:8080/#/c/18639/12/be/src/exec/orc-metadata-utils.cc@311 PS12, Line 311: std::string field_id_str = child->getAttributeValue(ICEBERG_FIELD_ID); : child_field_id = GetFieldIdFromStr(field_id_str); : } else { : child_field_id = GetGeneratedFieldID(child); > nit: For readability, you could move it to a function e.g. "GetGeneratedFie Done http://gerrit.cloudera.org:8080/#/c/18639/12/be/src/exec/parquet/parquet-metadata-utils.cc File be/src/exec/parquet/parquet-metadata-utils.cc: http://gerrit.cloudera.org:8080/#/c/18639/12/be/src/exec/parquet/parquet-metadata-utils.cc@835 PS12, Line 835: const int& field_id) const { > nit: you could add LIKELY here Done http://gerrit.cloudera.org:8080/#/c/18639/12/be/src/exec/parquet/parquet-metadata-utils.cc@838 PS12, Line 838: SchemaNode* child = &node->children[idx]; : : int child_field_id = 0; : > nit: For readability, you could move it to a function e.g. "GetGeneratedFie Done -- To view, visit http://gerrit.cloudera.org:8080/18639 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I77570bbfc2fcc60c2756812d7210110e8cc11ccc Gerrit-Change-Number: 18639 Gerrit-PatchSet: 14 Gerrit-Owner: Gergely Fürnstáhl <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Gergely Fürnstáhl <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tamas Mate <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Mon, 11 Jul 2022 11:30:01 +0000 Gerrit-HasComments: Yes
