Gergely Fürnstáhl has posted comments on this change. ( http://gerrit.cloudera.org:8080/18639 )
Change subject: IMPALA-11034: Resolve schema of old data files in migrated Iceberg tables ...................................................................... Patch Set 14: (2 comments) http://gerrit.cloudera.org:8080/#/c/18639/14/be/src/exec/parquet/parquet-metadata-utils.cc File be/src/exec/parquet/parquet-metadata-utils.cc: http://gerrit.cloudera.org:8080/#/c/18639/14/be/src/exec/parquet/parquet-metadata-utils.cc@847 PS14, Line 847: break > We could return idx here and INVALID_ID at L850, in case we didn't find a c I would not return INVALID_ID on L850. idx >= size signals that we ran out of columns, INVALID_ID signals that the file is corrupted and handled differently by the caller http://gerrit.cloudera.org:8080/#/c/18639/12/tests/query_test/test_iceberg.py File tests/query_test/test_iceberg.py: http://gerrit.cloudera.org:8080/#/c/18639/12/tests/query_test/test_iceberg.py@106 PS12, Line 106: time.sleep(1) > you should add annotation "@SkipIf.not_hdfs" S3A supports "hadoop fs" calls and "hdfs dfs" is translated into that. Tested it on S3 environment and the test passes, no need to skip -- To view, visit http://gerrit.cloudera.org:8080/18639 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I77570bbfc2fcc60c2756812d7210110e8cc11ccc Gerrit-Change-Number: 18639 Gerrit-PatchSet: 14 Gerrit-Owner: Gergely Fürnstáhl <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Gergely Fürnstáhl <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tamas Mate <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Wed, 13 Jul 2022 14:03:17 +0000 Gerrit-HasComments: Yes
