Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18639 )
Change subject: IMPALA-11034: Resolve schema of old data files in migrated Iceberg tables ...................................................................... Patch Set 16: Code-Review+2 (1 comment) LGTM! http://gerrit.cloudera.org:8080/#/c/18639/14/be/src/exec/parquet/parquet-metadata-utils.cc File be/src/exec/parquet/parquet-metadata-utils.cc: http://gerrit.cloudera.org:8080/#/c/18639/14/be/src/exec/parquet/parquet-metadata-utils.cc@847 PS14, Line 847: retur > I would not return INVALID_ID on L850. idx >= size signals that we ran out OK, I see that at L802 we check the case when 'file_idx >= node->children.size()' -- To view, visit http://gerrit.cloudera.org:8080/18639 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I77570bbfc2fcc60c2756812d7210110e8cc11ccc Gerrit-Change-Number: 18639 Gerrit-PatchSet: 16 Gerrit-Owner: Gergely Fürnstáhl <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Gergely Fürnstáhl <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tamas Mate <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Thu, 14 Jul 2022 08:13:12 +0000 Gerrit-HasComments: Yes
