Aman Sinha has posted comments on this change. ( http://gerrit.cloudera.org:8080/18744 )
Change subject: IMPALA-11443: Fix partitoned top-n with -1 input cardinality ...................................................................... Patch Set 1: Code-Review+1 (1 comment) The code change lgtm. One comment about the test. http://gerrit.cloudera.org:8080/#/c/18744/1/testdata/workloads/functional-planner/queries/PlannerTest/limit-pushdown-partitioned-top-n.test File testdata/workloads/functional-planner/queries/PlannerTest/limit-pushdown-partitioned-top-n.test: http://gerrit.cloudera.org:8080/#/c/18744/1/testdata/workloads/functional-planner/queries/PlannerTest/limit-pushdown-partitioned-top-n.test@858 PS1, Line 858: # Relies on functional.alltypessmall not having stats and running this test with Can we always rely on functional.alltypessmall not having stats ? FWIW, PlannerTest.testKudu() creates a test-only external table without stats for a particular test. Something similar could be an option. I am ok with the alltypessmall if we have used it elsewhere (or similar tables) with the no stats assumption. -- To view, visit http://gerrit.cloudera.org:8080/18744 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7e2dc7df397dc4684e6510a200f381a74c8dd984 Gerrit-Change-Number: 18744 Gerrit-PatchSet: 1 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Mon, 18 Jul 2022 20:42:10 +0000 Gerrit-HasComments: Yes
