Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/18744 )
Change subject: IMPALA-11443: Fix partitoned top-n with -1 input cardinality ...................................................................... Patch Set 1: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/18744/1/fe/src/main/java/org/apache/impala/planner/SortNode.java File fe/src/main/java/org/apache/impala/planner/SortNode.java: http://gerrit.cloudera.org:8080/#/c/18744/1/fe/src/main/java/org/apache/impala/planner/SortNode.java@465 PS1, Line 465: getChild(0).cardinality_ * avgRowSize_ Maybe not quite in the scope of this patch but is it possible that we have cardinality == -1 AND avgRowSize_ < 0 because of corrupt stats? This way the product would be incorrect but positive so we don't recognise it as incorrect on the next line. -- To view, visit http://gerrit.cloudera.org:8080/18744 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7e2dc7df397dc4684e6510a200f381a74c8dd984 Gerrit-Change-Number: 18744 Gerrit-PatchSet: 1 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Tue, 19 Jul 2022 08:40:56 +0000 Gerrit-HasComments: Yes
