Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/18744 )
Change subject: IMPALA-11443: Fix partitoned top-n with -1 input cardinality ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/18744/1/fe/src/main/java/org/apache/impala/planner/SortNode.java File fe/src/main/java/org/apache/impala/planner/SortNode.java: http://gerrit.cloudera.org:8080/#/c/18744/1/fe/src/main/java/org/apache/impala/planner/SortNode.java@465 PS1, Line 465: getChild(0).cardinality_ * avgRowSize_ > Maybe not quite in the scope of this patch but is it possible that we have I thing that avgRowSize_ cannot be negative. We could add a precondition for that, but I would prefer to not do it this in the current commit to avoid breaking currently working queries. http://gerrit.cloudera.org:8080/#/c/18744/1/testdata/workloads/functional-planner/queries/PlannerTest/limit-pushdown-partitioned-top-n.test File testdata/workloads/functional-planner/queries/PlannerTest/limit-pushdown-partitioned-top-n.test: http://gerrit.cloudera.org:8080/#/c/18744/1/testdata/workloads/functional-planner/queries/PlannerTest/limit-pushdown-partitioned-top-n.test@858 PS1, Line 858: # Relies on functional.tinytable not having stats and running this test with > Can we always rely on functional.alltypessmall not having stats ? cardinality=unavailable in the plan at scan node ensures that the test will break if functional.alltypessmall has stats. Switched to functional,tinytable as I saw that we rely on it having stats in other tests -- To view, visit http://gerrit.cloudera.org:8080/18744 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7e2dc7df397dc4684e6510a200f381a74c8dd984 Gerrit-Change-Number: 18744 Gerrit-PatchSet: 3 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Fri, 22 Jul 2022 12:26:46 +0000 Gerrit-HasComments: Yes
