Kurt Deschler has posted comments on this change. ( http://gerrit.cloudera.org:8080/18801 )
Change subject: IMPALA-11464: Skip listing staging dirs to avoid failures on them ...................................................................... Patch Set 2: (2 comments) Should any of the file iterator changes made for IMPALA-9122 be reverted as well as part of this fix? http://gerrit.cloudera.org:8080/#/c/18801/2/fe/src/main/java/org/apache/impala/common/FileSystemUtil.java File fe/src/main/java/org/apache/impala/common/FileSystemUtil.java: http://gerrit.cloudera.org:8080/#/c/18801/2/fe/src/main/java/org/apache/impala/common/FileSystemUtil.java@995 PS2, Line 995: if (isIgnoredDir(fileStatus.getPath())) { Should this check be performed first so that temporary files are consistently ignored? http://gerrit.cloudera.org:8080/#/c/18801/2/fe/src/main/java/org/apache/impala/common/FileSystemUtil.java@998 PS2, Line 998: return; This case should set curFile_ to something since the original function set it in all cases. -- To view, visit http://gerrit.cloudera.org:8080/18801 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic848e6c8563a1e0bf294cd50167dfc40f66a56cb Gerrit-Change-Number: 18801 Gerrit-PatchSet: 2 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Tue, 02 Aug 2022 11:44:46 +0000 Gerrit-HasComments: Yes
