Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/18801 )
Change subject: IMPALA-11464: Skip listing staging dirs to avoid failures on them ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/18801/2/tests/metadata/test_recursive_listing.py File tests/metadata/test_recursive_listing.py: http://gerrit.cloudera.org:8080/#/c/18801/2/tests/metadata/test_recursive_listing.py@147 PS2, Line 147: """Test REFRESH survives with concurrent add/remove ops on large staging/tmp dirs Nit: we could mention also here that this is a regression test for IMPALA-11464. http://gerrit.cloudera.org:8080/#/c/18801/2/tests/metadata/test_recursive_listing.py@211 PS2, Line 211: def test_partition_dir_removed_inflight(self, vector, unique_database): This function and test_large_staging_dirs() are almost completely the same. Can we make a general parametrized helper function that, based on the parameters, produces the behaviour of test_large_staging_dirs() or test_partition_dir_removed_inflight()? Then the top level test functions would only need to call that helper with different parameters. http://gerrit.cloudera.org:8080/#/c/18801/2/tests/util/hdfs_util.py File tests/util/hdfs_util.py: http://gerrit.cloudera.org:8080/#/c/18801/2/tests/util/hdfs_util.py@325 PS2, Line 325: def move(self, src, dst): Do we use it somewhere? Or would you like to add it in case it's useful in the future? -- To view, visit http://gerrit.cloudera.org:8080/18801 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic848e6c8563a1e0bf294cd50167dfc40f66a56cb Gerrit-Change-Number: 18801 Gerrit-PatchSet: 2 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Tue, 02 Aug 2022 11:52:14 +0000 Gerrit-HasComments: Yes
