Xiang Yang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18801 )
Change subject: IMPALA-11464: Skip listing staging dirs to avoid failures on them ...................................................................... Patch Set 4: (4 comments) http://gerrit.cloudera.org:8080/#/c/18801/4/fe/src/main/java/org/apache/impala/common/FileSystemUtil.java File fe/src/main/java/org/apache/impala/common/FileSystemUtil.java: http://gerrit.cloudera.org:8080/#/c/18801/4/fe/src/main/java/org/apache/impala/common/FileSystemUtil.java@942 PS4, Line 942: if (LOG.isTraceEnabled()) { Hi quanlong, why isTraceEnabled and then LOG.info() ? http://gerrit.cloudera.org:8080/#/c/18801/4/fe/src/main/java/org/apache/impala/common/FileSystemUtil.java@988 PS4, Line 988: if (LOG.isTraceEnabled()) { generally for log4j, there is no need to add additional log level judgement. http://gerrit.cloudera.org:8080/#/c/18801/4/fe/src/main/java/org/apache/impala/common/FileSystemUtil.java@1006 PS4, Line 1006: if (LOG.isTraceEnabled()) { same as above http://gerrit.cloudera.org:8080/#/c/18801/4/fe/src/main/java/org/apache/impala/common/FileSystemUtil.java@1007 PS4, Line 1007: LOG.trace("listed sub dir: " + fileStatus.getPath()); better to use '{}' to substitute args, see https://www.slf4j.org/faq.html#logging_performance -- To view, visit http://gerrit.cloudera.org:8080/18801 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic848e6c8563a1e0bf294cd50167dfc40f66a56cb Gerrit-Change-Number: 18801 Gerrit-PatchSet: 4 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Xiang Yang <[email protected]> Gerrit-Comment-Date: Wed, 03 Aug 2022 03:18:21 +0000 Gerrit-HasComments: Yes
