Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/18531 )
Change subject: IMPALA-10453: Support file pruning via runtime filters on Iceberg ...................................................................... Patch Set 11: (2 comments) http://gerrit.cloudera.org:8080/#/c/18531/10/be/src/exec/file-metadata-utils.h File be/src/exec/file-metadata-utils.h: http://gerrit.cloudera.org:8080/#/c/18531/10/be/src/exec/file-metadata-utils.h@42 PS10, Line 42: void Open(RuntimeState* state, const HdfsFileDesc* file_desc); > What do you think about "Init" or something like that? I am ok with "init" + a comment that it can be called several times :) http://gerrit.cloudera.org:8080/#/c/18531/9/fe/src/main/java/org/apache/impala/planner/IcebergScanNode.java File fe/src/main/java/org/apache/impala/planner/IcebergScanNode.java: http://gerrit.cloudera.org:8080/#/c/18531/9/fe/src/main/java/org/apache/impala/planner/IcebergScanNode.java@116 PS9, Line 116: super.computeNodeResourceProfile(queryOptions); : // Increase t > It is because the HdfsScanNodeBase::IcebergPartitionPassesFilters creates a Hmm, that looks more like an issue to me than something that is actually needed - the tuple is only used during IcebergPartitionPassesFilters, and we won't use it later, right? We could use a different mem pool, e.g. iceberg_partition_filtering_mem_pool, that could be reseted after each use. -- To view, visit http://gerrit.cloudera.org:8080/18531 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7762e1238bdf236b85d2728881a402a2bb41f36a Gerrit-Change-Number: 18531 Gerrit-PatchSet: 11 Gerrit-Owner: Tamas Mate <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Gergely Fürnstáhl <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tamas Mate <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Tue, 02 Aug 2022 15:44:09 +0000 Gerrit-HasComments: Yes
