Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/18531 )
Change subject: IMPALA-10453: Support file pruning via runtime filters on Iceberg ...................................................................... Patch Set 12: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/18531/12/fe/src/main/java/org/apache/impala/planner/IcebergScanNode.java File fe/src/main/java/org/apache/impala/planner/IcebergScanNode.java: http://gerrit.cloudera.org:8080/#/c/18531/12/fe/src/main/java/org/apache/impala/planner/IcebergScanNode.java@127 PS12, Line 127: long templateTupleSize = checkedMultiply((long)avgRowSize_, : nodeResourceProfile_.getThreadReservation()); Tbh I don't think that 1 tuple per scanner really matters, mem estimate / reservation matters mainly from the megabyte scale. So my preference would be simply remove this function to reduce the complexity of this change. -- To view, visit http://gerrit.cloudera.org:8080/18531 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7762e1238bdf236b85d2728881a402a2bb41f36a Gerrit-Change-Number: 18531 Gerrit-PatchSet: 12 Gerrit-Owner: Tamas Mate <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Gergely Fürnstáhl <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Tamas Mate <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Wed, 03 Aug 2022 11:53:05 +0000 Gerrit-HasComments: Yes
