Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18531 )
Change subject: IMPALA-10453: Support file pruning via runtime filters on Iceberg ...................................................................... Patch Set 12: (2 comments) http://gerrit.cloudera.org:8080/#/c/18531/7/be/src/exec/file-metadata-utils.h File be/src/exec/file-metadata-utils.h: http://gerrit.cloudera.org:8080/#/c/18531/7/be/src/exec/file-metadata-utils.h@48 PS7, Line 48: > Done We use pointers for output parameters so that at the callsites it's obvious that the function modifies the parameters, e.g.: foo(&a); Using a reference to a unique_ptr<T> doesn't have this property, because at the callsite we have this: foo(a); So it's better to use native pointers for output parameters. Also, we won't need the boilerplate code with unique_ptrs and make_unique etc. http://gerrit.cloudera.org:8080/#/c/18531/12/be/src/exec/hdfs-scan-node-base.cc File be/src/exec/hdfs-scan-node-base.cc: http://gerrit.cloudera.org:8080/#/c/18531/12/be/src/exec/hdfs-scan-node-base.cc@636 PS12, Line 636: NULL nit: nullptr -- To view, visit http://gerrit.cloudera.org:8080/18531 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7762e1238bdf236b85d2728881a402a2bb41f36a Gerrit-Change-Number: 18531 Gerrit-PatchSet: 12 Gerrit-Owner: Tamas Mate <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Gergely Fürnstáhl <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Tamas Mate <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Wed, 03 Aug 2022 14:07:35 +0000 Gerrit-HasComments: Yes
