Xianqing He has posted comments on this change. ( http://gerrit.cloudera.org:8080/18711 )
Change subject: IMPALA-11418: A statement that returns at most one row need not to spool results ...................................................................... Patch Set 12: > Patch Set 12: Verified+1 Thanks Quanlong, Riza Suminto for reviewing the code. I have fixed the failed tests and modified Frontend.java for fix the failed test https://jenkins.impala.io/job/ubuntu-16.04-from-scratch/17546/testReport/junit/custom_cluster.test_executor_groups/TestExecutorGroups/test_admission_control_with_multiple_coords_and_exec_groups/ Please review again. Before this the query option will reset in https://github.com/apache/impala/blob/66484a4c081f3242750a3a0e04159dd4580b37a4/fe/src/main/java/org/apache/impala/service/Frontend.java#L1977 and caused impalad crashed. In planner the query option spool_query_results=false, but in backend the spool_query_results=true -- To view, visit http://gerrit.cloudera.org:8080/18711 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icd4d73c21106048df68a270cf03d4abd56bd3aac Gerrit-Change-Number: 18711 Gerrit-PatchSet: 12 Gerrit-Owner: Xianqing He <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Xianqing He <[email protected]> Gerrit-Comment-Date: Wed, 21 Sep 2022 09:38:59 +0000 Gerrit-HasComments: No
