Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/18711 )
Change subject: IMPALA-11418: A statement that returns at most one row need not to spool results ...................................................................... Patch Set 12: (5 comments) Looks good to me! Just wonder if another approach that reserves one row (max) worth of memory instead of 4MB would be reasonable too. http://gerrit.cloudera.org:8080/#/c/18711/12//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18711/12//COMMIT_MSG@15 PS12, Line 15: the exception nit. prevent the exception http://gerrit.cloudera.org:8080/#/c/18711/12/fe/src/main/java/org/apache/impala/analysis/AnalysisContext.java File fe/src/main/java/org/apache/impala/analysis/AnalysisContext.java: http://gerrit.cloudera.org:8080/#/c/18711/12/fe/src/main/java/org/apache/impala/analysis/AnalysisContext.java@476 PS12, Line 476: returnsAtMostOneRow Can you please check if this excludes structs? http://gerrit.cloudera.org:8080/#/c/18711/12/fe/src/main/java/org/apache/impala/analysis/AnalysisContext.java@479 PS12, Line 479: returns nit. returning. http://gerrit.cloudera.org:8080/#/c/18711/12/testdata/workloads/functional-planner/queries/PlannerTest/result-spooling.test File testdata/workloads/functional-planner/queries/PlannerTest/result-spooling.test: http://gerrit.cloudera.org:8080/#/c/18711/12/testdata/workloads/functional-planner/queries/PlannerTest/result-spooling.test@141 PS12, Line 141: with no from clause nit. returning one constant row http://gerrit.cloudera.org:8080/#/c/18711/12/testdata/workloads/functional-planner/queries/PlannerTest/result-spooling.test@141 PS12, Line 141: # Select stmt Suggest to add all these new test queries to testdata/workloads/functional-query/queries/QueryTest/result-spooling.test to help verify that the implicit disabling of the spooling produces correct SQL result. -- To view, visit http://gerrit.cloudera.org:8080/18711 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icd4d73c21106048df68a270cf03d4abd56bd3aac Gerrit-Change-Number: 18711 Gerrit-PatchSet: 12 Gerrit-Owner: Xianqing He <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Qifan Chen <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Xianqing He <[email protected]> Gerrit-Comment-Date: Fri, 23 Sep 2022 13:00:43 +0000 Gerrit-HasComments: Yes
