Xianqing He has posted comments on this change. ( http://gerrit.cloudera.org:8080/18711 )
Change subject: IMPALA-11418: A statement that returns at most one row need not to spool results ...................................................................... Patch Set 13: (7 comments) > Patch Set 12: > > (5 comments) > > Looks good to me! > > Just wonder if another approach that reserves one row (max) worth of memory > instead of 4MB would be reasonable too. This is a good idea. I have submitted the issue IMPALA-11613 and will optimize it in that commit. http://gerrit.cloudera.org:8080/#/c/18711/12//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18711/12//COMMIT_MSG@15 PS12, Line 15: prevent the e > nit. prevent the exception Done http://gerrit.cloudera.org:8080/#/c/18711/12/fe/src/main/java/org/apache/impala/analysis/AnalysisContext.java File fe/src/main/java/org/apache/impala/analysis/AnalysisContext.java: http://gerrit.cloudera.org:8080/#/c/18711/12/fe/src/main/java/org/apache/impala/analysis/AnalysisContext.java@476 PS12, Line 476: returnsAtMostOneRow > Can you please check if this excludes structs? It's not excluded structs. I will optimize it in IMPALA-11613. http://gerrit.cloudera.org:8080/#/c/18711/12/fe/src/main/java/org/apache/impala/analysis/AnalysisContext.java@479 PS12, Line 479: returni > nit. returning. Done http://gerrit.cloudera.org:8080/#/c/18711/12/fe/src/main/java/org/apache/impala/service/Frontend.java File fe/src/main/java/org/apache/impala/service/Frontend.java: http://gerrit.cloudera.org:8080/#/c/18711/12/fe/src/main/java/org/apache/impala/service/Frontend.java@1824 PS12, Line 1824: threshol > nit: threshold Done http://gerrit.cloudera.org:8080/#/c/18711/12/fe/src/main/java/org/apache/impala/service/Frontend.java@1831 PS12, Line 1831: threshol > nit: threshold Done http://gerrit.cloudera.org:8080/#/c/18711/12/testdata/workloads/functional-planner/queries/PlannerTest/result-spooling.test File testdata/workloads/functional-planner/queries/PlannerTest/result-spooling.test: http://gerrit.cloudera.org:8080/#/c/18711/12/testdata/workloads/functional-planner/queries/PlannerTest/result-spooling.test@141 PS12, Line 141: # Select stmt > Suggest to add all these new test queries to testdata/workloads/functional- I will continue optimize result spooling in IMPALA-11613 and add tests to testdata/workloads/functional-query/queries/QueryTest/result-spooling.test in that commit. http://gerrit.cloudera.org:8080/#/c/18711/12/testdata/workloads/functional-planner/queries/PlannerTest/result-spooling.test@141 PS12, Line 141: returning one consta > nit. returning one constant row Done -- To view, visit http://gerrit.cloudera.org:8080/18711 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icd4d73c21106048df68a270cf03d4abd56bd3aac Gerrit-Change-Number: 18711 Gerrit-PatchSet: 13 Gerrit-Owner: Xianqing He <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Qifan Chen <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Xianqing He <[email protected]> Gerrit-Comment-Date: Mon, 26 Sep 2022 09:36:37 +0000 Gerrit-HasComments: Yes
