Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19050 )
Change subject: [IMPALA-11625] Support create/drop materialized view syntax on IMPALA ...................................................................... Patch Set 5: (30 comments) http://gerrit.cloudera.org:8080/#/c/19050/5/be/src/service/client-request-state.cc File be/src/service/client-request-state.cc: http://gerrit.cloudera.org:8080/#/c/19050/5/be/src/service/client-request-state.cc@708 PS5, Line 708: // portion of the operation). The exception is if the user specified IF NOT EXISTS and the table already line too long (106 > 90) http://gerrit.cloudera.org:8080/#/c/19050/5/be/src/service/client-request-state.cc@1116 PS5, Line 1116: // When the coordinator is not available for CTAS/CMvAS that requires a coordinator, check line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/19050/5/fe/src/main/java/org/apache/impala/analysis/CreateMaterializedViewAsSelectStmt.java File fe/src/main/java/org/apache/impala/analysis/CreateMaterializedViewAsSelectStmt.java: http://gerrit.cloudera.org:8080/#/c/19050/5/fe/src/main/java/org/apache/impala/analysis/CreateMaterializedViewAsSelectStmt.java@51 PS5, Line 51: private final static EnumSet<THdfsFileFormat> SUPPORTED_INSERT_MATERIALIZED_VIEW_FORMATS = line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/19050/5/fe/src/main/java/org/apache/impala/analysis/CreateMaterializedViewAsSelectStmt.java@68 PS5, Line 68: public CreateMaterializedViewAsSelectStmt(CmvasParams params, List<PlanHint> planHints) { line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/19050/5/fe/src/main/java/org/apache/impala/analysis/CreateMaterializedViewAsSelectStmt.java@104 PS5, Line 104: if (!SUPPORTED_INSERT_MATERIALIZED_VIEW_FORMATS.contains(createStmt_.getFileFormat())) { line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/19050/5/fe/src/main/java/org/apache/impala/analysis/CreateMaterializedViewAsSelectStmt.java@122 PS5, Line 122: throw new AnalysisException("Query statement in CreateMaterializedViewAsSelectStmt " + line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/19050/5/fe/src/main/java/org/apache/impala/analysis/CreateMaterializedViewAsSelectStmt.java@129 PS5, Line 129: throw new AnalysisException("Query statement in CreateMaterializedViewAsSelectStmt " + line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/19050/5/fe/src/main/java/org/apache/impala/analysis/DropTableOrViewStmt.java File fe/src/main/java/org/apache/impala/analysis/DropTableOrViewStmt.java: http://gerrit.cloudera.org:8080/#/c/19050/5/fe/src/main/java/org/apache/impala/analysis/DropTableOrViewStmt.java@142 PS5, Line 142: // DROP MATERIALIZED VIEW IF EXISTS 'table' succeeds, similarly to Hive, but unlike postgres. line too long (101 > 90) http://gerrit.cloudera.org:8080/#/c/19050/5/fe/src/main/java/org/apache/impala/analysis/DropTableOrViewStmt.java@145 PS5, Line 145: "DROP MATERIALIZED VIEW not allowed on a none-materialized view: %s.%s", dbName_, getTbl())); line too long (105 > 90) http://gerrit.cloudera.org:8080/#/c/19050/5/fe/src/main/java/org/apache/impala/analysis/DropTableOrViewStmt.java@151 PS5, Line 151: "DROP TABLE/VIEW not allowed on a materialized view: %s.%s", dbName_, getTbl())); line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/19050/5/fe/src/main/java/org/apache/impala/analysis/ToSqlUtils.java File fe/src/main/java/org/apache/impala/analysis/ToSqlUtils.java: http://gerrit.cloudera.org:8080/#/c/19050/5/fe/src/main/java/org/apache/impala/analysis/ToSqlUtils.java@477 PS5, Line 477: return getCreateTableSql(dbName, tableName, tableComment, columnsSql, partitionColumnsSql, line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/19050/5/fe/src/main/java/org/apache/impala/analysis/ToSqlUtils.java@478 PS5, Line 478: primaryKeysSql, foreignKeysSql, kuduPartitionByParams, sortProperties, tblProperties, line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/19050/5/fe/src/main/java/org/apache/impala/planner/DistributedPlanner.java File fe/src/main/java/org/apache/impala/planner/DistributedPlanner.java: http://gerrit.cloudera.org:8080/#/c/19050/5/fe/src/main/java/org/apache/impala/planner/DistributedPlanner.java@80 PS5, Line 80: && !singleNodePlan.hasLimit() || analysisResult.isCreateMaterializedViewAsSelectStmt()) { line too long (97 > 90) http://gerrit.cloudera.org:8080/#/c/19050/5/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/19050/5/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@2671 PS5, Line 2671: params.getTable_name().table_name, "Load for DROP TABLE/VIEW/MATERIALIZED VIEW ", null); line too long (98 > 90) http://gerrit.cloudera.org:8080/#/c/19050/5/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@2747 PS5, Line 2747: } else if (params.isSetIs_table() && ((params.is_table && existingTbl instanceof View) line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/19050/5/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@6391 PS5, Line 6391: table.getMetaStoreTable().getTableType().endsWith(MATERIALIZED_VIEW.toString()))) { line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/19050/5/fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java File fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java: http://gerrit.cloudera.org:8080/#/c/19050/5/fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java@4224 PS5, Line 4224: "as select * from functional.jointbl", "CREATE MATERIALIZED VIEW must specify location !"); line too long (99 > 90) http://gerrit.cloudera.org:8080/#/c/19050/5/fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java@4227 PS5, Line 4227: AnalyzesOk("create materialized view newmv stored as parquetfile LOCATION '/mv/newmv'" + line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/19050/5/fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java@4236 PS5, Line 4236: AnalyzesOk("create materialized view newmv partitioned by (year) LOCATION '/mv/newmv' as " + line too long (96 > 90) http://gerrit.cloudera.org:8080/#/c/19050/5/fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java@4258 PS5, Line 4258: " LOCATION '/mv/db_does_not_exist/newmv' as select * from functional.jointbl limit 1", line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/19050/5/fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java@4259 PS5, Line 4259: "Query statement in CreateMaterializedViewAsSelectStmt should not have LimitElement!"); line too long (95 > 90) http://gerrit.cloudera.org:8080/#/c/19050/5/fe/src/test/java/org/apache/impala/analysis/ParserTest.java File fe/src/test/java/org/apache/impala/analysis/ParserTest.java: http://gerrit.cloudera.org:8080/#/c/19050/5/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@3283 PS5, Line 3283: ParsesOk("CREATE MATERIALIZED VIEW Foo.Bar AS SELECT int_col, bool_col from tbl limit 10"); line too long (95 > 90) http://gerrit.cloudera.org:8080/#/c/19050/5/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@3285 PS5, Line 3285: ParsesOk("CREATE MATERIALIZED VIEW IF NOT EXISTS Foo.Bar LOCATION '/a/b' AS SELECT * from foo"); line too long (100 > 90) http://gerrit.cloudera.org:8080/#/c/19050/5/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@3287 PS5, Line 3287: ParsesOk("CREATE MATERIALIZED VIEW Foo ROW FORMAT DELIMITED STORED AS PARQUETFILE AS SELECT 1"); line too long (100 > 90) http://gerrit.cloudera.org:8080/#/c/19050/5/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@3288 PS5, Line 3288: ParsesOk("CREATE MATERIALIZED VIEW Foo TBLPROPERTIES ('a'='b', 'c'='d') AS SELECT * from bar"); line too long (99 > 90) http://gerrit.cloudera.org:8080/#/c/19050/5/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@3297 PS5, Line 3297: ParserError("CREATE MATERIALIZED VIEW Foo ROW FORMAT DELIMITED STORED AS PARQUET AS SELECT"); line too long (97 > 90) http://gerrit.cloudera.org:8080/#/c/19050/5/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@3298 PS5, Line 3298: ParserError("CREATE MATERIALIZED VIEW Foo ROW FORMAT DELIMITED STORED AS PARQUET AS WITH"); line too long (95 > 90) http://gerrit.cloudera.org:8080/#/c/19050/5/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@3311 PS5, Line 3311: ParsesOk("CREATE MATERIALIZED VIEW Foo PARTITIONED BY (a) ROW FORMAT DELIMITED STORED AS " + line too long (96 > 90) http://gerrit.cloudera.org:8080/#/c/19050/5/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@3316 PS5, Line 3316: ParserError("CREATE MATERIALIZED VIEW Foo PARTITIONED BY (a=2, b) AS SELECT * from Bar"); line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/19050/5/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@3317 PS5, Line 3317: ParserError("CREATE MATERIALIZED VIEW Foo PARTITIONED BY (a, b=2) AS SELECT * from Bar"); line too long (93 > 90) -- To view, visit http://gerrit.cloudera.org:8080/19050 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I77fdd34bf04a8994a215170747249356cd40622b Gerrit-Change-Number: 19050 Gerrit-PatchSet: 5 Gerrit-Owner: pengdou <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Fri, 30 Sep 2022 07:36:41 +0000 Gerrit-HasComments: Yes
