Baike Xia has posted comments on this change. ( http://gerrit.cloudera.org:8080/19050 )
Change subject: [IMPALA-11625] Support create/drop materialized view syntax on IMPALA ...................................................................... Patch Set 7: (2 comments) http://gerrit.cloudera.org:8080/#/c/19050/6/fe/src/main/java/org/apache/impala/analysis/Analyzer.java File fe/src/main/java/org/apache/impala/analysis/Analyzer.java: http://gerrit.cloudera.org:8080/#/c/19050/6/fe/src/main/java/org/apache/impala/analysis/Analyzer.java@124 PS6, Line 124: MATERIALIZED_VIEW This one doesn't seem to be in use. Can we delete it? http://gerrit.cloudera.org:8080/#/c/19050/6/fe/src/main/java/org/apache/impala/analysis/ToSqlUtils.java File fe/src/main/java/org/apache/impala/analysis/ToSqlUtils.java: http://gerrit.cloudera.org:8080/#/c/19050/6/fe/src/main/java/org/apache/impala/analysis/ToSqlUtils.java@645 PS6, Line 645: if (view.getMetaStoreTable().getTableType().equals(MATERIALIZED_VIEW.toString())) That doesn't seem right. enum cannot be compared with string to obtain true. Should write it this way? if (view.getMetaStoreTable().getTableType().name().equals(MATERIALIZED_VIEW.toString())) -- To view, visit http://gerrit.cloudera.org:8080/19050 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I77fdd34bf04a8994a215170747249356cd40622b Gerrit-Change-Number: 19050 Gerrit-PatchSet: 7 Gerrit-Owner: pengdou <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Baike Xia <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Thu, 13 Oct 2022 12:22:47 +0000 Gerrit-HasComments: Yes
