pengdou has posted comments on this change. ( http://gerrit.cloudera.org:8080/19050 )
Change subject: [IMPALA-11625] Support create/drop materialized view syntax on IMPALA ...................................................................... Patch Set 8: (2 comments) http://gerrit.cloudera.org:8080/#/c/19050/6/fe/src/main/java/org/apache/impala/analysis/Analyzer.java File fe/src/main/java/org/apache/impala/analysis/Analyzer.java: http://gerrit.cloudera.org:8080/#/c/19050/6/fe/src/main/java/org/apache/impala/analysis/Analyzer.java@124 PS6, Line 124: > This one doesn't seem to be in use. Can we delete it? Done http://gerrit.cloudera.org:8080/#/c/19050/6/fe/src/main/java/org/apache/impala/analysis/ToSqlUtils.java File fe/src/main/java/org/apache/impala/analysis/ToSqlUtils.java: http://gerrit.cloudera.org:8080/#/c/19050/6/fe/src/main/java/org/apache/impala/analysis/ToSqlUtils.java@645 PS6, Line 645: if (view.getMetaStoreTable().getTableType().equals(MATERIALIZED_VIEW.toString())) > That doesn't seem right. enum cannot be compared with string to obtain true the result of view.getMetaStoreTable() is instance of org.apache.hadoop.hive.metastore.api.Table, the define of org.apache.hadoop.hive.metastore.api.Table#getTableType as following: @Nullable public String getTableType() { return this.tableType; } so the usage is right. -- To view, visit http://gerrit.cloudera.org:8080/19050 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I77fdd34bf04a8994a215170747249356cd40622b Gerrit-Change-Number: 19050 Gerrit-PatchSet: 8 Gerrit-Owner: pengdou <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Baike Xia <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: pengdou <[email protected]> Gerrit-Comment-Date: Fri, 14 Oct 2022 02:30:03 +0000 Gerrit-HasComments: Yes
