Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/18798 )
Change subject: IMPALA-6684: Fix untracked memory in KRPC ...................................................................... Patch Set 15: (7 comments) Should we clean up Thrift RPC related code, which use TRowBatch? http://gerrit.cloudera.org:8080/#/c/18798/15/be/src/runtime/krpc-data-stream-sender.h File be/src/runtime/krpc-data-stream-sender.h: http://gerrit.cloudera.org:8080/#/c/18798/15/be/src/runtime/krpc-data-stream-sender.h@262 PS15, Line 262: B nit: bytes http://gerrit.cloudera.org:8080/#/c/18798/15/be/src/runtime/krpc-data-stream-sender.h@265 PS15, Line 265: Bytes nit: bytes http://gerrit.cloudera.org:8080/#/c/18798/15/be/src/runtime/row-batch.h File be/src/runtime/row-batch.h: http://gerrit.cloudera.org:8080/#/c/18798/15/be/src/runtime/row-batch.h@70 PS15, Line 70: std::unique_ptr<FreePool> not necessary to define the pointer as unique_ptr, regular pointer should be fine. http://gerrit.cloudera.org:8080/#/c/18798/15/be/src/runtime/row-batch.h@101 PS15, Line 101: Serialize() nit: serialization http://gerrit.cloudera.org:8080/#/c/18798/15/be/src/runtime/row-batch.h@137 PS15, Line 137: if tuple_data_length_ > tuple_data_capacity_ new allocation will be necessary If tuple_data_length_ > tuple_data_capacity_, we need to reallocate data buffer. http://gerrit.cloudera.org:8080/#/c/18798/15/be/src/runtime/row-batch.h@142 PS15, Line 142: Serialize() serialization. http://gerrit.cloudera.org:8080/#/c/18798/15/be/src/runtime/row-batch.h@143 PS15, Line 143: The compression_scratch_ and its length and capacity will be std::swap The compression_scratch_, its length and capacity will be swapped -- To view, visit http://gerrit.cloudera.org:8080/18798 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2ba2b907ce4f275a7a1fb8cf75453c7003eb4b82 Gerrit-Change-Number: 18798 Gerrit-PatchSet: 15 Gerrit-Owner: Omid Shahidi <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Omid Shahidi <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Thu, 06 Oct 2022 17:09:00 +0000 Gerrit-HasComments: Yes
