Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/18798 )
Change subject: IMPALA-6684: Fix untracked memory in KRPC ...................................................................... Patch Set 17: Code-Review+1 (2 comments) looks good, only a few minor comments http://gerrit.cloudera.org:8080/#/c/18798/17/be/src/runtime/row-batch.h File be/src/runtime/row-batch.h: http://gerrit.cloudera.org:8080/#/c/18798/17/be/src/runtime/row-batch.h@493 PS17, Line 493: /// This implementation is added to separate the logical path for protobuf and Thrift : /// serialization : /// : /// 'full_dedup': true if full deduplication is used. : /// 'tuple_offsets': Updated to contain offsets of all tuples into 'tuple_data' upon : /// return. There are a total of num_rows * num_tuples_per_row offsets. : /// An offset of -1 records a NULL. : /// 'tuple_data': Updated to hold the serialized tuples' data. If 'is_compressed' : /// is true, this is LZ4 compressed. : /// 'uncompressed_size': Updated with the uncompressed size of 'tuple_data'. : /// 'is_compressed': true if compression is applied on 'tuple_data'. : /// : /// Returns error status if serialization failed. Returns OK otherwise. : /// : /// TODO: clean this up once the thrift RPC implementation is removed. : Status SerializeThrift(bool full_dedup, vector<int32_t>* tuple_offsets, : string* tuple_data, int64_t* uncompressed_size, bool* is_compressed); remove http://gerrit.cloudera.org:8080/#/c/18798/17/be/src/runtime/row-batch.h@511 PS17, Line 511: Shared implementation between thrift and protobuf to deserialize a row batch. remove -- To view, visit http://gerrit.cloudera.org:8080/18798 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2ba2b907ce4f275a7a1fb8cf75453c7003eb4b82 Gerrit-Change-Number: 18798 Gerrit-PatchSet: 17 Gerrit-Owner: Omid Shahidi <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Omid Shahidi <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Wed, 12 Oct 2022 20:17:59 +0000 Gerrit-HasComments: Yes
