Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/18798 )
Change subject: IMPALA-6684: Fix untracked memory in KRPC ...................................................................... Patch Set 15: (4 comments) http://gerrit.cloudera.org:8080/#/c/18798/15//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18798/15//COMMIT_MSG@18 PS15, Line 18: The thrift implementation is left unchanged and : the protobuf implementation is seperated. Should we remove those code? They are not used anymore. http://gerrit.cloudera.org:8080/#/c/18798/15//COMMIT_MSG@20 PS15, Line 20: Also mention the code change in Planner. http://gerrit.cloudera.org:8080/#/c/18798/15/fe/src/main/java/org/apache/impala/planner/DataStreamSink.java File fe/src/main/java/org/apache/impala/planner/DataStreamSink.java: http://gerrit.cloudera.org:8080/#/c/18798/15/fe/src/main/java/org/apache/impala/planner/DataStreamSink.java@64 PS15, Line 64: is nit: are http://gerrit.cloudera.org:8080/#/c/18798/15/fe/src/main/java/org/apache/impala/planner/DataStreamSink.java@75 PS15, Line 75: int outboundBatchesPerReceiver = 2; : int bufferPerOutboundBatch = 2; Could you add a comment why set these two variables as 2? -- To view, visit http://gerrit.cloudera.org:8080/18798 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2ba2b907ce4f275a7a1fb8cf75453c7003eb4b82 Gerrit-Change-Number: 18798 Gerrit-PatchSet: 15 Gerrit-Owner: Omid Shahidi <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Omid Shahidi <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Thu, 06 Oct 2022 18:51:59 +0000 Gerrit-HasComments: Yes
