Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/18798 )
Change subject: IMPALA-6684: Fix untracked memory in KRPC ...................................................................... Patch Set 18: (3 comments) Since we removed TRowBatch-based serialization, I tried to merge Serialize with SerializeInternal in patch set 18. This seems to improve benchmark a bit. http://gerrit.cloudera.org:8080/#/c/18798/17/be/src/runtime/row-batch.h File be/src/runtime/row-batch.h: http://gerrit.cloudera.org:8080/#/c/18798/17/be/src/runtime/row-batch.h@46 PS17, Line 46: class Tuple; > remove Done http://gerrit.cloudera.org:8080/#/c/18798/17/be/src/runtime/row-batch.h@493 PS17, Line 493: /// Implementation for protobuf to deserialize a row batch. : /// : /// 'input_tuple_offsets': an int32_t array of tuples; offsets into 'input_tuple_data'. : /// Used for populating the tuples in the row batch with actual pointers. : /// : /// 'input_tuple_data': contains pointer and size of tuples' data buffer. : /// If 'is_compressed' is true, the data is compressed. : /// : /// 'uncompressed_size': the uncompressed size of 'input_tuple_data' if it's compressed. : /// : /// 'is_compressed': True if 'input_tuple_data' is compressed. : /// : /// 'tuple_data': buffer of 'uncompressed_size' bytes for holding tuple data. : void Deserialize(const kudu::Slice& input_tuple_offsets, : const kudu::Slice& input_tuple_data, int64_t uncompressed_size, bool is_compressed, : uint8_t* tuple_data); : > remove Done http://gerrit.cloudera.org:8080/#/c/18798/17/be/src/runtime/row-batch.h@511 PS17, Line 511: string and collection data). This is the size of the row batch after removing > remove Done -- To view, visit http://gerrit.cloudera.org:8080/18798 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2ba2b907ce4f275a7a1fb8cf75453c7003eb4b82 Gerrit-Change-Number: 18798 Gerrit-PatchSet: 18 Gerrit-Owner: Omid Shahidi <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Omid Shahidi <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Thu, 13 Oct 2022 05:37:11 +0000 Gerrit-HasComments: Yes
