Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19186 )
Change subject: IMPALA-11696: Fix incorrect warnings of ignoring delimiters on text/sequence tables ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/19186/1/fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java File fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java: http://gerrit.cloudera.org:8080/#/c/19186/1/fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java@2363 PS1, Line 2363: String.format( : "create table new_table row format delimited %s stored as %s as select *" : + " from functional.child_table", rowFormat, format) Nit: we could extract this string to before the conditional because it is the same in both branches. http://gerrit.cloudera.org:8080/#/c/19186/1/fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java@2638 PS1, Line 2638: String.format( : "create table new_table (i int) row format delimited %s stored as %s", : rowFormat, fileFormats[formatIndx]) See L2363. -- To view, visit http://gerrit.cloudera.org:8080/19186 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0871b94dcd2290723699c21227a576e8a6a09b5a Gerrit-Change-Number: 19186 Gerrit-PatchSet: 1 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Thu, 03 Nov 2022 13:17:43 +0000 Gerrit-HasComments: Yes
